Fix Bugzilla Issue 24637 -- [REG 2.104] Cannot insert const/immutable elements into DList

[RubyTheRoobster]

trafficstars

[dlang-bot]

Thanks for your pull request and interest in making D better, @RubyTheRoobster! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	14138	major	std.parallelism.task breaks @safety
✓	15315	normal	can break immutable with std.algorithm.move
✓	20870	normal	std.outbuffer.printf is trusted
✓	20872	normal	std.array.assocArray trusts user-provided 'front' for values
✓	22293	enhancement	Nullable should define opCast!bool
✗	23300	normal	std.array : array wrongly propagates scopeness of source
✓	24637	regression	[REG 2.104] Cannot insert const/immutable elements into DList
✓	24667	normal	goo.gl is going away
✓	24685	major	std.stdio.File.rawRead allows reading raw pointers from files in @safe code

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#9042"

[RubyTheRoobster]

BuildKite is failing with:

CMake Error at cmake/Modules/FindLLVM.cmake:62 (message):
  Unsupported LLVM version 14.0.0 found (/bin/llvm-config).  At least version
  15.0 is required.  You can also set variables 'LLVM_ROOT_DIR' or
  'LLVM_CONFIG' to use a different LLVM installation.
Call Stack (most recent call first):
  cmake/Modules/FindLLVM.cmake:190 (_LLVM_FAIL)
  CMakeLists.txt:37 (find_package)

This seems to be a bug.

[kinke]

AFAIK, this depends on @ibuclaw re-creating his Buildkite agents using the latest docker image definition: https://github.com/dlang/ci/pull/489#issuecomment-2218942102

[RazvanN7]

@RubyTheRoobster maybe a rebase will fix the failing buildkite test.

[RubyTheRoobster]

I have never had to perform a rebase before, so I have no idea if all of the extra commits are acceptable or not.

[CyberShadow]

Unfortunately no, they are an indication that something went wrong with the rebase.

[LightBender]

This is being closed because of the incorrect rebase. Please reopen with just the initial commits. @thewilsonator if you're feeling like a project...