phobos
phobos copied to clipboard
Fix Issue 24550 - - formattedWrite should support string interpolation
Thanks for your pull request and interest in making D better, @RubyTheRoobster! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:andReturns:)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
| Auto-close | Bugzilla | Severity | Description |
|---|---|---|---|
| ✓ | 24550 | enhancement | formattedWrite should support string interpolation |
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub run digger -- build "master + phobos#9041"
please retitle the commit message "Fix Bugzliia Issue 24550 - - formattedWrite should support string interpolation"
BuildKite seems to be failing because it doesn't properly recognize string interpolation syntax.
My understanding is that the "formatted" part of formattedWrite refers to the format string. If it's using interpolation, it's not really a "formatted" write, is it?
@RubyTheRoobster I agree with @pbackus that these methods are for format-strings and not IES strings. As such, I am going to close this PR, but if you think this is an error, please feel free to reopen it.