phobos icon indicating copy to clipboard operation
phobos copied to clipboard

Properly mark lines constructor

Open schveiguy opened this issue 1 year ago • 4 comments

Still need

  • [ ] bug report
  • [ ] test

I just first want to see that it doesn't break anything.

schveiguy avatar Jul 29 '24 01:07 schveiguy

Thanks for your pull request, @schveiguy!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#9035"

dlang-bot avatar Jul 29 '24 01:07 dlang-bot

Replaces #9034

schveiguy avatar Jul 29 '24 01:07 schveiguy

I'm completely confused on the style problem. What style thing is wrong?

schveiguy avatar Jul 29 '24 01:07 schveiguy

That is unrelated

thewilsonator avatar Jul 29 '24 01:07 thewilsonator

@schveiguy can you complete the Bug Report and Test cases? Will merge once those are in. The style failures appear spurious.

LightBender avatar Oct 27 '24 07:10 LightBender

Looks like the macOS GHA got stuck once again :/

0xEAB avatar Jan 01 '25 22:01 0xEAB

Ah, thanks @0xEAB I had this tab open and was planning on getting to it. Sorry.

schveiguy avatar Jan 02 '25 02:01 schveiguy

No worries, you’re welcome :)

0xEAB avatar Jan 02 '25 02:01 0xEAB