phobos icon indicating copy to clipboard operation
phobos copied to clipboard

Placate a bunch of Allman style violation for #8805

Open thewilsonator opened this issue 11 months ago • 7 comments

I don't necessarily agree with all of these but they show up as conflict for the other PR.

This is a subset, I'll do the other ones later.

thewilsonator avatar Sep 18 '23 01:09 thewilsonator

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8817"

dlang-bot avatar Sep 18 '23 01:09 dlang-bot

Can we fix Dscanner instead?

CyberShadow avatar Sep 18 '23 08:09 CyberShadow

@WebFreak001 ?

thewilsonator avatar Sep 18 '23 08:09 thewilsonator

any update on this?

RazvanN7 avatar Oct 17 '23 13:10 RazvanN7

ah none yet, I forgot about this PR

WebFreak001 avatar Oct 18 '23 03:10 WebFreak001

ping

thewilsonator avatar Dec 15 '23 13:12 thewilsonator

Can we fix Dscanner instead?

how about stop using it, even.

Enforce trivial matters of style with a formatter, not a linter.

maxhaton avatar Jan 08 '24 00:01 maxhaton