phobos
phobos copied to clipboard
Fix issue 14543: std.algorithm.searching.until does n…
…ot handle range sentinels nicely. This may break user code, unlike (https://github.com/dlang/phobos/pull/8568)
Thanks for your pull request and interest in making D better, @jamesragray! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:andReturns:)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
| Auto-close | Bugzilla | Severity | Description |
|---|---|---|---|
| ✓ | 14542 | minor | Table of contents in specification PDF is broken |
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub run digger -- build "master + phobos#8570"
Thanks! Looks like everything's green on buildkite, so maybe we can get away with this.
(assuming this fixes the issue in question) please amend the commit title to be Fix issue 14543: <issue title goes here> so the bot picks it up properly.
@jamesragray Simply changing the title will not get the bot to pick this up. You need to make a new commit that contains "Fix Issue 14543" in its commit message so that the bot knows to close the bugzilla entry automatically and so that you get bugzilla points that you can see on the leaderboards [1][2] (you can even win prizes, for more info check this blog post[3]). You need to:
git commit --amend -m "Fix Issue 14542 - std.algorithm.searching.until does not handle range sentinels nicely"
git push $your_branch $your_remote_repo
[1] https://bot.dlang.io/contributor_stats [2] https://bot.dlang.io/contributor_stats_cycle [3] https://dlang.org/blog/2021/09/16/bugzilla-reward-system/