phobos icon indicating copy to clipboard operation
phobos copied to clipboard

Issue 14543 std.algorithm.searching.until does not handle range sentinels nicely

Open jamesragray opened this issue 2 years ago • 4 comments

Implemented: https://issues.dlang.org/show_bug.cgi?id=14543 This is somewhere between a bug fix and a new feature because you could argue the old behaviour is wrong.

jamesragray avatar Sep 14 '22 21:09 jamesragray

Thanks for your pull request and interest in making D better, @jamesragray! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
14543 normal std.algorithm.searching.until does not handle range sentinels nicely

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8568"

dlang-bot avatar Sep 14 '22 21:09 dlang-bot

BTW if you think this PR fixes the issue, make sure the title of (one of) the commit's message starts with Fix issue 14543: followed by the title of the issue.

thewilsonator avatar Sep 15 '22 13:09 thewilsonator

Might be worth submitting a draft PR that just changes OpenRight.no to include the full sentinel, and see if any of the projects tested on Buildkite break. If we can get away with it, that would be a much cleaner solution.

cc @atilaneves, this introduces a new public symbol.

pbackus avatar Sep 16 '22 15:09 pbackus

I have done that here: https://github.com/dlang/phobos/pull/8570

jamesragray avatar Sep 16 '22 18:09 jamesragray

The problem has been fixed here https://github.com/dlang/phobos/pull/8570

jamesragray avatar Sep 21 '22 16:09 jamesragray