phobos icon indicating copy to clipboard operation
phobos copied to clipboard

overhaul documentation of std.string indexOf-like functions

Open wolframw opened this issue 1 year ago • 2 comments

wolframw avatar Sep 07 '22 22:09 wolframw

Thanks for your pull request and interest in making D better, @wolframw! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8560"

dlang-bot avatar Sep 07 '22 22:09 dlang-bot

A quick read looks good so far. But as documentation is not my strong suit somebody else should have a look.

burner avatar Sep 08 '22 08:09 burner