phobos icon indicating copy to clipboard operation
phobos copied to clipboard

std.complex: Add member function to returnComplex as a native type

Open ibuclaw opened this issue 2 years ago • 5 comments

So that std.complex can be passed to extern(C) complex functions where ABI compatibility is required.

ibuclaw avatar Mar 21 '22 17:03 ibuclaw

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8415"

dlang-bot avatar Mar 21 '22 17:03 dlang-bot

As Dennis mentioned, this should have documentation. Maybe a documented unit test. The one you added would serve well IMO.

Otherwise LGTM.

dukc avatar Apr 06 '22 19:04 dukc

I took the liberty of rebasing this, adding a comment to the function and solving the buildkite failure.

@ibuclaw @dkorpel could please take a look?

RazvanN7 avatar Jun 06 '22 14:06 RazvanN7

Why not a Ddoc comment though?

dukc avatar Jun 06 '22 18:06 dukc

@dukc I simply followed the style that is currently present. But I made it a ddoc comment now.

RazvanN7 avatar Jul 05 '22 12:07 RazvanN7