phobos icon indicating copy to clipboard operation
phobos copied to clipboard

Make AffixAllocator take into account RCISharedAllocator

Open edi33416 opened this issue 6 years ago • 5 comments

edi33416 avatar Feb 21 '18 10:02 edi33416

Thanks for your pull request and interest in making D better, @edi33416! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6205"

dlang-bot avatar Feb 21 '18 10:02 dlang-bot

@jercaianu

edi33416 avatar Mar 28 '18 16:03 edi33416

I've moved the parent() logic inside the mixin template Impl as this also needs to infer the shared attribute.

edi33416 avatar Mar 28 '18 16:03 edi33416

@n8sh could you have another look at the code? Changed sync to use only one variable

edi33416 avatar Apr 26 '18 15:04 edi33416

@edi33416 What is the state of this PR? Should we pull it in?

RazvanN7 avatar Apr 29 '21 10:04 RazvanN7