phobos icon indicating copy to clipboard operation
phobos copied to clipboard

Fix Issue 6447: iota(BigInt) too

Open Biotronic opened this issue 6 years ago • 9 comments

This adds the missing overload for three-parameter iota as pointed out in Issue 6447, and should be enough to finally close the issue.

Biotronic avatar Sep 24 '17 13:09 Biotronic

Thanks for your pull request and interest in making D better, @Biotronic! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
6447 enhancement iota(BigInt) too

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#5745"

dlang-bot avatar Sep 24 '17 13:09 dlang-bot

As @wilzbach suggested, I united all iota overloads. This has the benefit of uniting functionality - where previously different overloads of iota supported different operations, now these operations are available on any iota overload whose parameter types support the necessary operations.

Biotronic avatar Sep 25 '17 08:09 Biotronic

Autotester is not happy(

DmitryOlshansky avatar Sep 25 '17 12:09 DmitryOlshansky

Believe me, I know. I've failed to get some of the unittests to run on my local machine, and the specific one that fails now works when I copy the code to a separate file.

Biotronic avatar Sep 25 '17 13:09 Biotronic

I'd suggest we leave uniting the overloads to a separate PR and get the fix merged.

MetaLang avatar Sep 25 '17 17:09 MetaLang

After repeated failed attempts at getting the unit tests to run, I decided to revert to the simple change that fixes 6447, and a greater rewrite will have to wait.

Biotronic avatar Sep 29 '17 22:09 Biotronic

Ping @andralex

JackStouffer avatar Nov 27 '17 21:11 JackStouffer

ping @andralex Do the changes look OK now? Apparently this has stalled. Let's get it moving again!

quickfur avatar Jan 26 '18 19:01 quickfur

Ping @andralex this needs a rebase but is this otherwise goo to go?

thewilsonator avatar Nov 23 '18 11:11 thewilsonator