phobos
phobos copied to clipboard
Fix Issue 6447: iota(BigInt) too
This adds the missing overload for three-parameter iota as pointed out in Issue 6447, and should be enough to finally close the issue.
Thanks for your pull request and interest in making D better, @Biotronic! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:
andReturns:
)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
Auto-close | Bugzilla | Severity | Description |
---|---|---|---|
✓ | 6447 | enhancement | iota(BigInt) too |
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub fetch digger
dub run digger -- build "master + phobos#5745"
As @wilzbach suggested, I united all iota overloads. This has the benefit of uniting functionality - where previously different overloads of iota supported different operations, now these operations are available on any iota overload whose parameter types support the necessary operations.
Autotester is not happy(
Believe me, I know. I've failed to get some of the unittests to run on my local machine, and the specific one that fails now works when I copy the code to a separate file.
I'd suggest we leave uniting the overloads to a separate PR and get the fix merged.
After repeated failed attempts at getting the unit tests to run, I decided to revert to the simple change that fixes 6447, and a greater rewrite will have to wait.
Ping @andralex
ping @andralex Do the changes look OK now? Apparently this has stalled. Let's get it moving again!
Ping @andralex this needs a rebase but is this otherwise goo to go?