phobos
phobos copied to clipboard
dlang
Added nothrow @nogc @safe to the allocate function.
Also added these flags to all the functons it calls. In order to make the functions safe I isolated the 'unsafe' parts inside @trusted lambda expressions, inspired by edi33416's pull request #6416. Additionally, added nothrow @nogc @safe to the allocateAll function, since it only calls allocate.
Thanks for your pull request and interest in making D better, @George-Alex-Berea! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:andReturns:)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
Your PR doesn't reference any Bugzilla issue.
If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub run digger -- build "master + phobos#10780"
No, I just need to take a good close look at those @trusted functions
