phobos icon indicating copy to clipboard operation
phobos copied to clipboard

Make KRR allocate `@safe`

Open denisa1208 opened this issue 1 year ago • 2 comments

My PR revives the original PR (https://github.com/dlang/phobos/actions/runs/12297111982/job/34317628480?pr=10585)

denisa1208 avatar Dec 12 '24 13:12 denisa1208

Thanks for your pull request and interest in making D better, @denisa1208! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10585"

dlang-bot avatar Dec 12 '24 13:12 dlang-bot

Reference: https://github.com/dlang/phobos/pull/6416

0xEAB avatar Dec 26 '24 04:12 0xEAB

This PR has had a broken CI for 6+ months, please reopen if you plan to continue working on this.

LightBender avatar Oct 27 '25 01:10 LightBender