most of phobos should be @safe-ly useable

[dlangBugzillaToGithub]

code (@MartinNowak) reported this on 2017-12-21T17:01:00Z

Transfered from https://issues.dlang.org/show_bug.cgi?id=18110

CC List

• andrei (@andralex)
• bugzilla (@WalterBright)
• bugzilla (@WalterBright)
• forestix
• greensunny12

Description

Tracking issue for phobos entities that should be @safe, but currently aren't.

Let's reference per-module/package issues if someone goes on a fixing spree, but first this issue is intended to collect such issues.

[dlangBugzillaToGithub]

code (@MartinNowak) commented on 2017-12-21T17:01:39Z

std.stdio.File.byLine:

Should be @safe as the internally used buffer is GC allocated, thus unexpected mutation of an escaped line is possible, but cannot cause a memory corruption.

@safe function 'foo' cannot call @system function 'std.stdio.File.byLine!(char, char).byLine'
@safe function 'foo' cannot call @system destructor 'std.stdio.File.ByLine!(char, char).ByLine.~this'
----
std.stdio.File.byLineCopy:

obviously

@safe function 'foo' cannot call @system function 'std.stdio.File.byLineCopy!(char, immutable(char)).byLineCopy'
@safe function 'foo' cannot call @system destructor 'std.stdio.File.ByLineCopy!(immutable(char), char).ByLineCopy.~this'

[dlangBugzillaToGithub]

andrei (@andralex) commented on 2017-12-21T18:51:34Z

I'd vote for this, but looks like voting has disappeared.

[dlangBugzillaToGithub]

greensunny12 commented on 2018-01-03T04:58:23Z

Made a quick pass through Phobos and started to create issues for an easier overview, progress tracking and management.
The list is still quite large atm.

[dlangBugzillaToGithub]

bugzilla (@WalterBright) commented on 2019-12-24T12:47:29Z

Although important, it's more an enhancement, than a bug, isn't it?

[0xEAB]

I’m not sure whether such omnibus issues are exactly a good fit on their own. We should probably split them up and replace them with a list of links to issues or a GitHub project.

@dlang/team-phobos What do you think?

[thewilsonator]

This should either be a project, or list (as todos) all the modules/functions/whatever as items.