D uninstaller nukes the entire D installation folder, including any user files

[dlangBugzillaToGithub]

Vladimir Panteleev (@CyberShadow) reported this on 2015-03-15T17:03:17Z

Transferred from https://issues.dlang.org/show_bug.cgi?id=14287

CC List

• Brad Anderson

Description

The D1 and D2 Windows uninstallers currently do a recursive rmdir on the installation directory:

  RMDir /r "$INSTDIR\dmd2"
  RMDir "$INSTDIR"

Two users who I've introduced to D have now pointed this out. Although no important data is lost, this is still rather unpleasant.

Ideally, we should only delete those files that we have installed, if they have not changed since installation. Deleting only the list of files that have been installed would also be acceptable.

For the moment, I've created a PR to warn users before the RMDir is executed:

https://github.com/D-Programming-Language/installer/pull/121