installer icon indicating copy to clipboard operation
installer copied to clipboard

Port Azure CI jobs to new GitHub Actions workflow

Open kinke opened this issue 2 years ago • 1 comments

kinke avatar Jul 24 '22 09:07 kinke

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

dlang-bot avatar Jul 24 '22 09:07 dlang-bot

@kinke who's going to be using this?

ibuclaw avatar Oct 03 '22 14:10 ibuclaw

Oh, completely forgot about this PR. ;) - No idea, but I was porting LDC CI from Azure Pipelines to GH Actions at that time, so thought I could port this stuff here too while memory is fresh...

kinke avatar Oct 03 '22 14:10 kinke

Looks good! Can you rebase (and apply the diff from HEAD) so we can merge ?

Geod24 avatar Oct 05 '22 13:10 Geod24

Done.

kinke avatar Oct 05 '22 14:10 kinke

Hmm, CI ran 2 months ago: https://github.com/dlang/installer/actions/workflows/build_windows.yml - not anymore apparently?

kinke avatar Oct 05 '22 14:10 kinke

Hmm, CI ran 2 months ago: https://github.com/dlang/installer/actions/workflows/build_windows.yml - not anymore apparently?

Not patient enough for the trigger to take effect. ;-)

ibuclaw avatar Oct 05 '22 14:10 ibuclaw