installer icon indicating copy to clipboard operation
installer copied to clipboard

Issue 19716 Add MANPATH to activate(.fish)

Open bolry opened this issue 6 years ago • 9 comments

Add the MANPATH environment variable to both the activate and activate.fish generated scripts in install.sh. Gives access to man pages for, e.g., dmd and dmd.conf.

bolry avatar Mar 03 '19 22:03 bolry

Thanks for your pull request and interest in making D better, @bolry! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19716 enhancement activate and activate.fish scripts do not add MANPATH

dlang-bot avatar Mar 03 '19 22:03 dlang-bot

Thanks a lot for your PR, but could you please add a simple test for it? Check travis.sh for details.

wilzbach avatar Mar 04 '19 05:03 wilzbach

Will do. Travis is new to me but I'll have a look.

bolry avatar Mar 04 '19 14:03 bolry

It's basically just one big shell script which we run in the CI. Let me know if you need help.

wilzbach avatar Mar 04 '19 14:03 wilzbach

Seemingly I need some ideas about the travis runtime environment to check it. Maybe man isn't available?

bolry avatar Mar 04 '19 21:03 bolry

I presume LDC just doesn't come with a man page or has it somewhere else?

wilzbach avatar Mar 04 '19 21:03 wilzbach

I've changed to only add MANPATH for dmd compilers.

bolry avatar Mar 13 '19 16:03 bolry

@bolry Request review and resolution of any conflicts associated with this pull request. Let's whip this in shape for merger.

AndrewEdwards avatar Sep 07 '20 00:09 AndrewEdwards

@wilzbach, I doubt @bolry is with us anymore. Do you mind taking over and seeing this to completion?

AndrewEdwards avatar Sep 21 '20 01:09 AndrewEdwards