installer
installer copied to clipboard
Issue 19716 Add MANPATH to activate(.fish)
Add the MANPATH environment variable to both the activate and activate.fish generated scripts in install.sh. Gives access to man pages for, e.g., dmd and dmd.conf.
Thanks for your pull request and interest in making D better, @bolry! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:andReturns:)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
| Auto-close | Bugzilla | Severity | Description |
|---|---|---|---|
| ✗ | 19716 | enhancement | activate and activate.fish scripts do not add MANPATH |
Thanks a lot for your PR, but could you please add a simple test for it? Check travis.sh for details.
Will do. Travis is new to me but I'll have a look.
It's basically just one big shell script which we run in the CI. Let me know if you need help.
Seemingly I need some ideas about the travis runtime environment to check it. Maybe man isn't available?
I presume LDC just doesn't come with a man page or has it somewhere else?
I've changed to only add MANPATH for dmd compilers.
@bolry Request review and resolution of any conflicts associated with this pull request. Let's whip this in shape for merger.
@wilzbach, I doubt @bolry is with us anymore. Do you mind taking over and seeing this to completion?