dub
dub copied to clipboard
dlang
Qualify NativePath members
Doesn't compile because Vibe.d has different qualifiers.
Oops, thanks. Forgot to compile with unittests.
Fixed via https://github.com/dlang/dub/compare/e230fd0234ac42c60af9eeefefa6611c72e65072..fcbed3642763e9db8c2189e8f2e2eb9ec1400ad4.
dub test pass locally now. Ok to merge.
Ehh, I'm clueless about the CI errors. How can a simple adding of qualifiers break CI in any way when dub test passes locally?
How do you compile? Test what the CI is doing. Building optionally with vibe-core is probably what breaks it.
Building optionally with vibe-core is probably what breaks it.
How do I do that? I find no reference to vibe-core in top dub.sdl.
Do you mean any of the dub.sdl-configurations
configuration "library-nonet" {
dependency "vibe-d:http" version=">=0.9.0 <0.10.0" optional=true
targetType "library"
excludedSourceFiles "source/app.d"
}
configuration "dynamic-library-nonet" {
dependency "vibe-d:http" version=">=0.9.0 <0.10.0" optional=true
targetType "dynamicLibrary"
excludedSourceFiles "source/app.d"
}
?
How do you compile? Test what the CI is doing. Building optionally with vibe-core is probably what breaks it.
Yes, but the problem is that the travis.sh script fails locally in on master and I find it really to hard to understand its output. We really need to do something about its output so it becomes obvious what are errors and not.
How do you compile?
I do dub test locally.
Test what the CI is doing. Building optionally with vibe-core is probably what breaks it.
Grepping for vibe-core gives no hits. I don't understand what you mean.
I recommend to go with something like https://github.com/dlang/dub/pull/2821 instead. Closing as stalled.