dub icon indicating copy to clipboard operation
dub copied to clipboard

Create folders before copying file during generator finalization.

Open JudgeFish opened this issue 4 years ago • 3 comments
trafficstars

Fixes #2145 Should be a simple start for my first contribution on github :)

Only tested on https://github.com/dayllenger/beamui.git so far. dub generate visuald :opengl now works and project files are generated.

Other older issues with relative paths in visuald generated subprojects are still hindering it to build though. Might have a solution for this later...

regards /Thomas

JudgeFish avatar Jun 12 '21 18:06 JudgeFish

Thanks for your pull request and interest in making D better, @JudgeFish! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

dlang-bot avatar Jun 12 '21 18:06 dlang-bot

Wouldn't it make more sense to have it be part of hardLinkFile ?

Geod24 avatar Jun 14 '21 00:06 Geod24

Looking at hardLinkFile(), it looks rather low-level so I would propose keeping it clean from extra behavior.

JudgeFish avatar Jun 14 '21 18:06 JudgeFish