druntime
druntime copied to clipboard
Fix Issue 23157 - undefined reference to `__cmsg_nxthdr' on Alpine Li…
…nux (musl libc)
The current definition of CMSG_NXTHDR
uses __cmsg_nxthdr
internally but __cmsg_nxthdr
is not provided on Alpine Linux (musl libc).
This request fixes the issue 23157 by fixing the definiiton of CMSG_NXTHDR
.
Here is a corresponding definition in musl libc header: https://git.musl-libc.org/cgit/musl/tree/include/sys/socket.h#n357
Thanks for your pull request and interest in making D better, @tom-tan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:
andReturns:
)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
Auto-close | Bugzilla | Severity | Description |
---|---|---|---|
✓ | 23157 | regression | undefined reference to `__cmsg_nxthdr' on Alpine Linux (musl libc) |
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub run digger -- build "stable + druntime#3830"
Can you please rebase this to restart the CI?
Buildkite succeeded now, but FreeBSD still has heisenbugs. Seems unrelated.