druntime icon indicating copy to clipboard operation
druntime copied to clipboard

CRuntime_Musl: More fixes for time64

Open omerfirmak opened this issue 4 years ago • 4 comments

The original PR (#3275) missed quite a few spots and conversions,
which led to the build on Alpine Linux failing with Aithmetic Exception
on core.time module constructor.
Links to the two offending commits are included.
For further issues / investigation, search for 'time64' in the git repository.

omerfirmak avatar Feb 26 '21 21:02 omerfirmak

Thanks for your pull request and interest in making D better, @omerfirmak! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#3384"

dlang-bot avatar Feb 26 '21 21:02 dlang-bot

What is the relationship between this PR and #3384 ? It seems that some changes are overlapping. Why not make a single PR with multiple commits?

RazvanN7 avatar Mar 02 '21 12:03 RazvanN7

This targets stable, #3383 dmd-cxx (presumably for bootstrapping).

kinke avatar Mar 02 '21 13:03 kinke

@kinke Ok to merge this?

RazvanN7 avatar Mar 12 '21 09:03 RazvanN7