minfo.d is no longer throwing Errors

[WalterBright]

assert() is better.

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#2795"

[WalterBright]

uncaught exception
object.Exception@src/rt_trap_exceptions_drt.d(4): foo

I have no idea where that is coming from :-(

[thewilsonator]

Here https://github.com/dlang/druntime/blob/master/test/exceptions/src/rt_trap_exceptions_drt.d#L4

[thewilsonator]

see also https://github.com/dlang/druntime/blob/master/test/exceptions/Makefile#L78-L80

[WalterBright]

@thewilsonator thanks!

[WalterBright]

buildkite fails with the completely unhelpful:

0.000s PASS debug64 etc.linux.memoryerror
--
  | done
  | make[1]: Leaving directory '/var/lib/buildkite-agent/builds/ci-agent-ebaba67d-b3b1-4059-a201-c882003602cf-8/dlang/druntime/druntime'
  | 🚨 Error: The command exited with status 2

[WalterBright]

The autotester logs show no failures, but list the tests as failing.

[Geod24]

The autotester logs show no failures, but list the tests as failing.

It does, but since the tests are run in parallel, the output is intertwined.

Testing cycle_abort
timelimit -t 10 ./generated/osx/release/64/test_cycles --DRT-oncycle=abort > generated/osx/release/64/cycle_abort.done 2>&1; test $? -eq 1
timelimit -t 10 generated/osx/debug/64/unittest/test_runner core.sys.windows.rpcnsip
timelimit -t 10 generated/osx/debug/64/unittest/test_runner core.sys.windows.rpcnterr
timelimit -t 10 generated/osx/debug/64/unittest/test_runner core.sys.windows.schannel
timelimit -t 10 generated/osx/debug/64/unittest/test_runner core.sys.windows.secext
timelimit -t 10 generated/osx/debug/64/unittest/test_runner core.sys.windows.security
timelimit -t 10 generated/osx/debug/64/unittest/test_runner core.sys.windows.servprov
timelimit -t 10 generated/osx/debug/64/unittest/test_runner core.sys.windows.setupapi
timelimit -t 10 generated/osx/debug/64/unittest/test_runner core.sys.windows.shellapi
timelimit -t 10 generated/osx/debug/64/unittest/test_runner core.sys.windows.shldisp
timelimit -t 10 generated/osx/debug/64/unittest/test_runner core.sys.windows.shlguid
timelimit -t 10 generated/osx/debug/64/unittest/test_runner core.sys.windows.shlobj
timelimit -t 10 generated/osx/debug/64/unittest/test_runner core.sys.windows.shlwapi
make[2]: *** [generated/osx/release/64/cycle_abort.done] Error 1
make[1]: *** [test/cycles/.run] Error 2
make: *** [unittest-release] Error 2
make: *** Waiting for unfinished jobs....

Test is checking for a specific return code, and I believe it changes from 1 to 4 with the switch to assert. See https://github.com/dlang/druntime/blob/3ead62a9bf4e0f866af10fdd3bc4edeb87237305/test/cycles/Makefile#L13