druntime icon indicating copy to clipboard operation
druntime copied to clipboard

std::optional

Open TurkeyMan opened this issue 6 years ago • 6 comments

The DMD union problem is fixed, this might get closer now...

TurkeyMan avatar Aug 31 '19 23:08 TurkeyMan

Thanks for your pull request and interest in making D better, @TurkeyMan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#2780"

dlang-bot avatar Aug 31 '19 23:08 dlang-bot

Still blocked on https://issues.dlang.org/show_bug.cgi?id=19902 ... which is a pretty bad regression!

TurkeyMan avatar Sep 05 '19 05:09 TurkeyMan

@TurkeyMan with @adamdruppe splitting the traits into two PRs, is this now no longer blocked?

Laeeth avatar Dec 23 '19 02:12 Laeeth

ping @TurkeyMan

12345swordy avatar Jun 11 '20 15:06 12345swordy

This may be able to move forward now. I'll poke at it when I get a few minutes.

TurkeyMan avatar Jun 12 '20 01:06 TurkeyMan

@TurkeyMan is this ready for review?

RazvanN7 avatar Apr 28 '22 15:04 RazvanN7