druntime
druntime copied to clipboard
FIX Issue 19643 - add missing Objective-C function calling convention
Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:
andReturns:
)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
Auto-close | Bugzilla | Severity | Description |
---|---|---|---|
✓ | 19643 | minor | core.demangle doesn't handle extern(Objective-C) correctly |
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub run digger -- build "master + druntime#2482"
The mangling for Objective-C has an ambiguity if used with the grammar from the website, see https://issues.dlang.org/show_bug.cgi?id=17310. IIRC the demangler should be able to handle these nevertheless, but you might want to add some symbols from that bug report to the tests, too.