druntime icon indicating copy to clipboard operation
druntime copied to clipboard

Published 20 hours ago • verified publisher icon dlang

Make rt_trapExceptions apply to fibers as well

Open Marenz opened this issue 8 years ago • 9 comments

Marenz avatar Apr 07 '16 13:04 Marenz

Fix Bugzilla Description
✓ 15895 Make rt_trapExceptions apply to fibers as well

dlang-bot avatar Apr 07 '16 19:04 dlang-bot

Ping.

Marenz avatar Apr 15 '16 17:04 Marenz

Ping

Marenz avatar May 01 '16 11:05 Marenz

It would be nice to get some feedback or at least any reaction to this.

Marenz avatar May 01 '16 11:05 Marenz

@MartinNowak trying a direct hilight

Marenz avatar May 05 '16 16:05 Marenz

So, I'm not as confident here because I don't use fibers but I think it is a good idea too.

adamdruppe avatar May 05 '16 19:05 adamdruppe

@MartinNowak ping ping ping

mathias-baumann-sociomantic avatar Aug 15 '16 09:08 mathias-baumann-sociomantic

One potential issue I see here is that Fiber.call actually documents how unhandled exceptions are treated (calling context resumes), and it even has a switch to set that behaviour. Is rt_trapExceptions actually documented anywhere?

dnadlinger avatar Aug 15 '16 12:08 dnadlinger

Only documentation I know of for this is

https://github.com/dlang/druntime/blob/15a227477a344583c4748d95492703901417f4f8/src/rt/dmain2.d#L142-L144

I can change the docu for Fiber.call to mention the behavior when rt_trapExceptions is set

mathias-baumann-sociomantic avatar Aug 15 '16 13:08 mathias-baumann-sociomantic