dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Attempt to fix all Macro issues

Open Emmankoko opened this issue 2 months ago • 3 comments

In an attempt to fix #define identifier identifier not being resolvable in D, we create D aliases for these macros that refer to identifiers. including a case check for identifiers actually caused conflicts with most of the inbuilt C compiler macros because of them define to identifiers and some are actually having no good use like macros that defines the same name eg. (#define if if) very common in C libs and headers. since they break D semantics, we do not allow it to break D semantics by just ignoring them like we have been doing. For now, I have kept a small table of symbols that easily conflicts but I think we can handle these well to integrate fully

we get to be able import macros that point to identifiers in D whiles not getting interfered by C builtins which D doesn't know.

more work needs to be done accordingly to win against C macro system fully.

@dkorpel

Emmankoko avatar Oct 24 '25 12:10 Emmankoko

Thanks for your pull request and interest in making D better, @Emmankoko! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22022"

dlang-bot avatar Oct 24 '25 12:10 dlang-bot

This is green, is it good to go?

thewilsonator avatar Oct 28 '25 15:10 thewilsonator

This is green, is it good to go?

nope.

want to fix most of the macros issues in this PR. so I'm tracking all.

Emmankoko avatar Oct 29 '25 11:10 Emmankoko