dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Fix #21256 - Empty hex string causes ICE

Open dkorpel opened this issue 3 months ago • 2 comments

Closes #21256

dkorpel avatar Sep 30 '25 15:09 dkorpel

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21923"

dlang-bot avatar Sep 30 '25 15:09 dlang-bot

Hold on, string casting to scalar types is really funky...

void main()
{
    string s;
    if (s) {} // ok
    if ("abc") {} // ok
    auto x = cast(bool) s; // frontend error
    auto y = cast(bool) "abc"; // ok
    auto z = cast(ubyte) s; // frontend error
    auto w = cast(ubyte) "abc"; // e2ir error
}

dkorpel avatar Sep 30 '25 15:09 dkorpel