dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Update g++ and clang versions for Ubuntu 22.04

Open 0xEAB opened this issue 8 months ago • 6 comments

As pointed out by @Geod24, there’s a few more things we might want to update as well: https://github.com/dlang/dmd/pull/21286#discussion_r2053487522

Not sure whether this works as is as Ubuntu is no longer packaging the vMAJOR.0.0 versions of clang. Hence filing as a draft.

0xEAB avatar Apr 22 '25 23:04 0xEAB

Thanks for your pull request, @0xEAB!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21291"

dlang-bot avatar Apr 22 '25 23:04 dlang-bot

Alright, we are pulling in blobs. My bad. This will have to be more sophisticated.

0xEAB avatar Apr 22 '25 23:04 0xEAB

@Geod24: What was the motivation for testing all these C++ compiler versions? Was there ever a regression caused/surfacing with a specific C++ compiler version?

To me, it would seem more useful to reduce these tests/jobs, and test recent versions instead. E.g., we could use Ubuntu 24 for Linux, where g++ is available from 9 to 13 (no PPA), and clang from 14 to 18 (by the distro directly, no need to resort to LLVM binaries on GitHub). On macOS, we could e.g. test the ~3 available (major) Xcode versions (as provided by the GHA images) and their Apple clang versions. And on Windows, VS 2019 and 2022 as available from GitHub Action images, plus maybe a few clang versions.

kinke avatar Apr 23 '25 12:04 kinke

What was the motivation for testing all these C++ compiler versions? Was there ever a regression caused/surfacing with a specific C++ compiler version?

I have a vague memory of wanting to be thorough, and getting burned on a few occasions when implementing template mangling. But to be fair, it was probably down to minor differences that weren't handled properly on our side, and I don't remember a regression being caught, so reducing the coverage would make sense to me too.

Geod24 avatar Apr 23 '25 13:04 Geod24

Okay, thx for the quick reply. I'll try to play around in a new PR.

kinke avatar Apr 23 '25 13:04 kinke

I’ll consider my patch superseded by #21295. Thanks for picking this up, @kinke!

Really looking forward to see all the janky blob and PPA stuff go.

0xEAB avatar Apr 23 '25 23:04 0xEAB

closing as https://github.com/dlang/dmd/pull/21295 was merged

thewilsonator avatar Jul 05 '25 12:07 thewilsonator