dmd
dmd copied to clipboard
Fix issue 11725: AA.dup should return mutable AA where possible
Reboot of #2838.
- Keeps same key type as I don't think there's any need to make that mutable.
- Changes a unittest to a versioned function as it doesn't do any runtime tests.
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:andReturns:)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
| Auto-close | Bugzilla | Severity | Description |
|---|---|---|---|
| ✓ | 11725 | normal | [AA] Cannot dup const AA |
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub run digger -- build "master + dmd#16979"
runnable/testaa3.d(118): Error: cannot cast
[5:4]toint[int]at compile time
I don't know why that happens.