dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Fix bugzilla issue 24716

Open thewilsonator opened this issue 1 year ago • 1 comments

checks for isNeedThisScope should check up the inheritance chain for nested classes.

E: Apparently this doesn't do what I thought it would. Will try again later.

thewilsonator avatar Aug 25 '24 07:08 thewilsonator

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24716 normal Outer class in derived inner class loses its type.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16810"

dlang-bot avatar Aug 25 '24 07:08 dlang-bot