dmd icon indicating copy to clipboard operation
dmd copied to clipboard

enable `preview=rvaluerefparam` by default

Open thewilsonator opened this issue 1 year ago • 4 comments

https://forum.dlang.org/thread/[email protected]

Will add changelog soon

thewilsonator avatar Aug 13 '24 09:08 thewilsonator

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16778"

dlang-bot avatar Aug 13 '24 09:08 dlang-bot

Lolwot? I didn't close this.

thewilsonator avatar Aug 13 '24 09:08 thewilsonator

The gods of Github don't want this ;)

Wasn't it broken for most of its lifetime ? Quite curious what the CI will say.

Geod24 avatar Aug 13 '24 09:08 Geod24

Wasn't it broken for most of its lifetime ?

Wasn't that noSharedAccess.

thewilsonator avatar Aug 13 '24 09:08 thewilsonator

Superseded by https://github.com/dlang/dmd/pull/17068

dkorpel avatar Jan 22 '25 09:01 dkorpel