dmd icon indicating copy to clipboard operation
dmd copied to clipboard

escape.d: fix `escapeExp` related to allocated memory

Open dkorpel opened this issue 1 year ago • 1 comments

When a variable is put in a new Struct(x) or dynamic array literal [x], it is not escaping x by value, because scope is not transitive and applies to the pointer / dynamic array, not the contents.

dkorpel avatar Jul 19 '24 18:07 dkorpel

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16734"

dlang-bot avatar Jul 19 '24 18:07 dlang-bot