dmd icon indicating copy to clipboard operation
dmd copied to clipboard

escape.d: Remove special case for `hasDualContext`

Open dkorpel opened this issue 1 year ago • 2 comments

I don't get this special case, it implies that returning &this.x in a struct member with dual context is actually returning this.x. While dual context does add an extra layer of indirection to the this pointer under the hood, dip1000 shouldn't treat struct field access differently because of it. The branch is not covered by tests, and dual context is in deprecated state, so I think it's safe to remove.

dkorpel avatar Jul 15 '24 15:07 dkorpel

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16707"

dlang-bot avatar Jul 15 '24 15:07 dlang-bot

Oh, so there is a runnable test that fails without it. Let me see...

dkorpel avatar Jul 15 '24 15:07 dkorpel