Adding a note

[trikko]

I’m adding this note because it took me a while to understand why the compilation with importc wasn’t working when using GitHub Actions: it was necessary to set up the environment with vcvars.

[dlang-bot]

Thanks for your pull request and interest in making D better, @trikko! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16472"

[thewilsonator]

Don't merge this yet, I want to improve the wording

[thewilsonator]

@trikko could you fill in the TODO with whatever it was that you did with Github action to make it work? (and remove the trailing space from the line that causes the pre-commit to fail)

[trikko]

I use this https://github.com/trikko/etichetta/blob/e39fd74f352aeacd6529701c2e878dd81e7ae34b/.github/workflows/windows.yml#L35 but I think it would be nice to have it integrated with dlang action.

[kinke]

I'm pretty sure this was fixed in https://github.com/dlang/dmd/pull/16248.

[kinke]

(That's also CI-tested: https://github.com/dlang/dmd/pull/16287)