dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Fix Bugzilla Issue 24504 - ImportC: Enum declarations with a mixture …

Open just-harry opened this issue 1 year ago • 4 comments

…of int and uint literal values cause errors, when targeting Windows, when debug info generation is enabled.


The value of a C enum's member can be a CastExp instead of an IntegerExp, causing these calls to toInteger to emit an error. So instead, if the value is a CastExp we make an IntegerExp out of it and go about as normal from there.

just-harry avatar Apr 15 '24 16:04 just-harry

I think that it's required for 'issue' to be spelled with a capital I so that the bot can pick it up. From the unittests of dlang bot I see that the combination of 'Bugzilla issue' is not present.

RazvanN7 avatar Apr 16 '24 09:04 RazvanN7

Maybe dlang-bot will pick it up if another comment is made?

EDIT: It didn't

just-harry avatar Apr 17 '24 01:04 just-harry

@just-harry The PR title doesn't matter. Also, comments don't matter. The only thing that is inspected by the bot is the commit message which needs to contain "Fix Bugzilla Issue 24504" (or some other combination, but this surely will work).

RazvanN7 avatar Apr 18 '24 07:04 RazvanN7

Still no link to the bugzilla issue...

WalterBright avatar May 05 '24 05:05 WalterBright