[foreach] Deprecate `ref` for array index or ForeachRangeStatement
Fix Bugzilla 24499 - foreach over a ref parameter to an rvalue should be an error Fix Bugzilla 24232 - ref for index of foreach for arrays is not allowed by spec but accepted by compiler
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:andReturns:)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
| Auto-close | Bugzilla | Severity | Description |
|---|---|---|---|
| ✓ | 24232 | normal | ref for index of foreach for arrays is not allowed by spec but accepted by compiler. |
| ✓ | 24499 | normal | foreach over a ref parameter to an rvalue should be an error |
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub run digger -- build "master + dmd#16381"
Fix Bugzilla 24232
For some reason that didn't get picked up by dlang-bot.
Edit: added a separate commit saying that, now it got picked up. Does it not find multiple issues?
Does it not find multiple issues?
I think it does when you list them like "Fix Bugzilla 24499, 24232"