dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Published 20 hours ago • verified publisher icon dlang

Revert the removal of `Expression.parens`

Open teodutu opened this issue 1 year ago • 1 comments

Having this at the Expression level is useful to libdparse and will also help fix this regression https://issues.dlang.org/show_bug.cgi?id=24371 whose underlying issue is that the lowering doesn't take parentheses into account.

This reverts the follwoing commits

  • 6e604e22b1e7f5f25ab2eb808a5691b2f7d3a9a0
  • e60d027582d2fa6c9236db7da5ead4b47d6e3f87
  • 71ffbe08c5fdfe91c11471b60a99a0f608cef628

teodutu avatar Feb 16 '24 16:02 teodutu

Thanks for your pull request, @teodutu!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16193"

dlang-bot avatar Feb 16 '24 16:02 dlang-bot