dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Print module names and timings when running unittests.

Open maxhaton opened this issue 2 years ago • 9 comments

maxhaton avatar Nov 11 '23 02:11 maxhaton

Thanks for your pull request, @maxhaton!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15795"

dlang-bot avatar Nov 11 '23 02:11 dlang-bot

Hijacking CI to see what this affects in the test suite

maxhaton avatar Nov 11 '23 02:11 maxhaton

@thewilsonator atila approved, I'm just checking that the test suite has anything to say. Something failed before but could've been flake

maxhaton avatar Dec 23 '23 22:12 maxhaton

I think the fail is legit but can't work out what

maxhaton avatar Dec 23 '23 23:12 maxhaton

module unittest_assert: FAILED in 73.000000 µs

ah ha

maxhaton avatar Dec 23 '23 23:12 maxhaton

@maxhaton can you add a screenshot to the PR description for future reference? I think users would also appreciate a changelog entry.

PetarKirov avatar Dec 25 '23 16:12 PetarKirov

@maxhaton have you figured out what is the cause of the testing pipeline failure? This is a cool feature and it would be neat to get this in.

RazvanN7 avatar Jan 10 '24 10:01 RazvanN7

@maxhaton have you figured out what is the cause of the testing pipeline failure? This is a cool feature and it would be neat to get this in.

I'm basically fixing the test suite first.

maxhaton avatar Jan 10 '24 12:01 maxhaton

@maxhaton any progress on this?

RazvanN7 avatar Aug 07 '24 15:08 RazvanN7