dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Fix Issue 24135 - Eponymous template member overloads not shown as call candidates

Open ntrel opened this issue 11 months ago • 3 comments

ntrel avatar Sep 04 '23 13:09 ntrel

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24135 enhancement Eponymous template member overloads not shown as call candidates

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15572"

dlang-bot avatar Sep 04 '23 13:09 dlang-bot

@maxhaton Ping

ntrel avatar Nov 06 '23 12:11 ntrel

I would also add a test with two eponymous templates that are in the same overload set but have different template parameters + an invalid call, just to make sure that both eponymous candidates are printed correctly.

Other than that, please rebase this and I will merge it.

RazvanN7 avatar Jan 10 '24 14:01 RazvanN7