dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Fix Issue 10602 - Error should state why wrong template lambda doesn'…

Open ntrel opened this issue 11 months ago • 2 comments

…t match expected function type

Also add ~~globals.errorBuf~~ ~~ErrorSinkBuffer~~ to divert gagged errors. (This will also be useful for another pull I'm working on).

ntrel avatar Aug 19 '23 15:08 ntrel

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
10602 normal Error should state why wrong template lambda doesn't match expected function type

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15544"

dlang-bot avatar Aug 19 '23 15:08 dlang-bot

@RazvanN7 @maxhaton Perhaps (separately) refactoring ~~TypeFunction.callMatch~~ FuncExp.matchType to take an ErrorSink would help? I'm looking at doing that.

ntrel avatar Aug 30 '23 18:08 ntrel