dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Issue 24003 - mangle inferred return/scope attributes in parameters

Open dkorpel opened this issue 2 years ago • 6 comments

Let's see how much ruckus this causes on buildkite

dkorpel avatar Jun 20 '23 16:06 dkorpel

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24003 normal return/scope inference does not end up in type to some degree

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15333"

dlang-bot avatar Jun 20 '23 16:06 dlang-bot

Just to be clear, this PR has the delegates get return and scope mangled in?

I agree, that is the best way forward. Anything else is hopeless.

WalterBright avatar Jun 23 '23 08:06 WalterBright

This applies to all parameters in the parameter list, but not the implicit this / delegate context parameter yet.

dkorpel avatar Jun 23 '23 08:06 dkorpel

buildkite/ddox fails because its documentation (based on dmd's json output) now includes new scope annotations on parameters

dkorpel avatar Jun 23 '23 11:06 dkorpel