dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Enable shortened methods by default

Open maxhaton opened this issue 1 year ago • 2 comments

The preview flag will still work but will print a deprecation message

maxhaton avatar Sep 21 '22 13:09 maxhaton

Thanks for your pull request, @maxhaton!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14462"

dlang-bot avatar Sep 21 '22 13:09 dlang-bot

made it undeprecated

how many releases do we keep them around for

maxhaton avatar Sep 21 '22 14:09 maxhaton

@maxhaton Can you update the changelog so we can get this in? See my suggestion (https://github.com/dlang/dmd/pull/14462#discussion_r977569439)

dkorpel avatar Sep 26 '22 12:09 dkorpel

@Geod24 changelog 4 u

maxhaton avatar Sep 29 '22 19:09 maxhaton

ERROR: Newly generated header file (/media/disk1/braddr/sandbox/at-client/pull-5344065-Linux_32_64/dmd/generated/linux/release/64/frontend.h) doesn't match with the reference header file (/media/disk1/braddr/sandbox/at-client/pull-5344065-Linux_32_64/dmd/compiler/src/dmd/frontend.h)

DETAILS:

diff --git a/media/disk1/braddr/sandbox/at-client/pull-5344065-Linux_32_64/dmd/compiler/src/dmd/frontend.h b/media/disk1/braddr/sandbox/at-client/pull-5344065-Linux_32_64/dmd/generated/linux/release/64/frontend.h
index 1626123..32353a1 100644
--- a/media/disk1/braddr/sandbox/at-client/pull-5344065-Linux_32_64/dmd/compiler/src/dmd/frontend.h
+++ b/media/disk1/braddr/sandbox/at-client/pull-5344065-Linux_32_64/dmd/generated/linux/release/64/frontend.h
@@ -628,7 +628,7 @@ struct Param final
         noSharedAccess(),
         previewIn(),
         inclusiveInContracts(),
-        shortenedMethods(),
+        shortenedMethods(true),
         fixImmutableConv(),
         fix16997(true),
         useInvariants((CHECKENABLE)0u),

===============
The file `src/dmd/frontend.h` seems to be out of sync. This is likely because
changes were made which affect the C++ interface used by GDC and LDC.

Geod24 avatar Sep 30 '22 11:09 Geod24

Ping @maxhaton

Geod24 avatar Oct 07 '22 15:10 Geod24