dmd
dmd copied to clipboard
Template visitor
This pull request aims to increase the flexibility of the Visitor class so that it can be used with other AST families than ASTCodegen and at the same time make minimum changes to existing code.
Thanks for your pull request and interest in making D better, @lucica28! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:andReturns:)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
Your PR doesn't reference any Bugzilla issue.
If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub run digger -- build "master + dmd#14424"
@ibuclaw Is this solution acceptable?
Where's the header update?
On a second thought, this actually does not seem to fix anything. The general idea would be to template the hdrgen module too so that we can bundle it with the parsing library.