dmd icon indicating copy to clipboard operation
dmd copied to clipboard

fix Issue 20956 - [DIP1000] @safe defeated by closure capturing ref p…

Open WalterBright opened this issue 3 years ago • 4 comments

…arameter

Very similar to fix for https://github.com/dlang/dmd/pull/14363

WalterBright avatar Aug 12 '22 07:08 WalterBright

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14364"

dlang-bot avatar Aug 12 '22 07:08 dlang-bot

Blocked by https://github.com/dlang/phobos/pull/8530

WalterBright avatar Aug 12 '22 08:08 WalterBright

I guess the test suite is going to drip-drip-drip the phobos failings one at a time.

WalterBright avatar Aug 12 '22 21:08 WalterBright

Blocked by bugs in Buildkite projects.

WalterBright avatar Aug 26 '22 17:08 WalterBright