dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Fix Issue 23284 - better floating point error messages.

Open maxhaton opened this issue 3 years ago • 2 comments

There was also a bug here in that real literals did not get a suffix attached.

maxhaton avatar Aug 07 '22 02:08 maxhaton

Thanks for your pull request, @maxhaton!

Bugzilla references

Auto-close Bugzilla Severity Description
23284 enhancement Enhance floating point not representable error message

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14354"

dlang-bot avatar Aug 07 '22 02:08 dlang-bot

Now to check if one can still write Complex literals

maxhaton avatar Aug 07 '22 02:08 maxhaton

@maxhaton Can you address the reviews?

dkorpel avatar Aug 24 '22 11:08 dkorpel

Am back from holiday now so yes

On Wed, 24 Aug 2022, 12:56 Dennis, @.***> wrote:

@maxhaton https://github.com/maxhaton Can you address the reviews?

— Reply to this email directly, view it on GitHub https://github.com/dlang/dmd/pull/14354#issuecomment-1225618031, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLI75D2JMWZEBEXVJVEI5TV2YEWRANCNFSM55ZU65WQ . You are receiving this because you were mentioned.Message ID: @.***>

maxhaton avatar Aug 24 '22 22:08 maxhaton

Not all addressed.

ibuclaw avatar Aug 31 '22 10:08 ibuclaw

https://issues.dlang.org/show_bug.cgi?id=23309

ibuclaw avatar Oct 23 '22 09:10 ibuclaw