dmd icon indicating copy to clipboard operation
dmd copied to clipboard

ImportC: disable blocks extension when preprocessing on OSX

Open drpriver opened this issue 3 years ago • 3 comments
trafficstars

Some C standard libary headers on macOS have versions of C standard library functions like qsort that take a clang block instead of a function pointer. ImportC does not implement (or parse) the block extension, so tell clang to disable them when preprocessing C source.

drpriver avatar Aug 05 '22 17:08 drpriver

Thanks for your pull request and interest in making D better, @drpriver! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14352"

dlang-bot avatar Aug 05 '22 17:08 dlang-bot

I feel like this should be documented, also is there a bug report for this?

thewilsonator avatar Aug 06 '22 02:08 thewilsonator

cc @WalterBright

RazvanN7 avatar Aug 08 '22 11:08 RazvanN7