dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Move top-level changelog to compiler/changelog

Open ibuclaw opened this issue 2 years ago • 9 comments

ibuclaw avatar Jul 10 '22 01:07 ibuclaw

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14286"

dlang-bot avatar Jul 10 '22 01:07 dlang-bot

But they are separate sections, aren't they ?

Geod24 avatar Jul 10 '22 01:07 Geod24

But they are separate sections, aren't they ?

Hmm.

ibuclaw avatar Jul 10 '22 01:07 ibuclaw

@Geod24 doing the inverse then, as having the top-level changelog would just be confusing.

ibuclaw avatar Jul 10 '22 13:07 ibuclaw

I think it'd be better to have them at the top. I would rather have a way to distinguish them, e.g. have pre-commit enforce that all changelog entry start with either dmd. or druntime. in their file name ?

Geod24 avatar Jul 10 '22 16:07 Geod24

I think it'd be better to have them at the top. I would rather have a way to distinguish them, e.g. have pre-commit enforce that all changelog entry start with either dmd. or druntime. in their file name ?

If we're going down that route, then changed.d will need to be updated to reflect the new scheme.

ibuclaw avatar Jul 10 '22 19:07 ibuclaw

I also think that having the changelog directory at the top would be better. Also, the point of the changelog is to give a high-level overview of what changed. I don't think that it is relevant, from a changelog reader perspective, whether the change was made in dmd or druntime, considering that there might be changes that affect both.

For interested parties, you can search the PR and see exactly what was modified. So, I would rather have a common changelog entry directory.

RazvanN7 avatar Jul 12 '22 08:07 RazvanN7

@ibuclaw what is your stance on this?

RazvanN7 avatar Jul 20 '22 09:07 RazvanN7

@ibuclaw any progress on this?

RazvanN7 avatar Sep 05 '22 09:09 RazvanN7

Just moved druntime changelogs to top-level then (apparently what I originally did).

Also require tools to be updated. https://github.com/dlang/tools/pull/452

Without either of these PRs in, we can't move forward with cutting a release.

@Geod24 @RazvanN7 you're both taking different conclusions, make up your minds. :-)

ibuclaw avatar Oct 09 '22 23:10 ibuclaw