dmd
dmd copied to clipboard
Move top-level changelog to compiler/changelog
Thanks for your pull request, @ibuclaw!
Bugzilla references
Your PR doesn't reference any Bugzilla issue.
If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub run digger -- build "master + dmd#14286"
But they are separate sections, aren't they ?
But they are separate sections, aren't they ?
Hmm.
@Geod24 doing the inverse then, as having the top-level changelog would just be confusing.
I think it'd be better to have them at the top. I would rather have a way to distinguish them, e.g. have pre-commit
enforce that all changelog entry start with either dmd.
or druntime.
in their file name ?
I think it'd be better to have them at the top. I would rather have a way to distinguish them, e.g. have
pre-commit
enforce that all changelog entry start with eitherdmd.
ordruntime.
in their file name ?
If we're going down that route, then changed.d will need to be updated to reflect the new scheme.
I also think that having the changelog directory at the top would be better. Also, the point of the changelog is to give a high-level overview of what changed. I don't think that it is relevant, from a changelog reader perspective, whether the change was made in dmd or druntime, considering that there might be changes that affect both.
For interested parties, you can search the PR and see exactly what was modified. So, I would rather have a common changelog entry directory.
@ibuclaw what is your stance on this?
@ibuclaw any progress on this?
Just moved druntime changelogs to top-level then (apparently what I originally did).
Also require tools to be updated. https://github.com/dlang/tools/pull/452
Without either of these PRs in, we can't move forward with cutting a release.
@Geod24 @RazvanN7 you're both taking different conclusions, make up your minds. :-)