dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Infer return on delegate without -dip1000

Open dkorpel opened this issue 2 years ago • 3 comments

Remove one of the last useDIP1000 branches hindering dip1000 by default.

dkorpel avatar May 19 '22 11:05 dkorpel

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14142"

dlang-bot avatar May 19 '22 11:05 dlang-bot

Changelog?

thewilsonator avatar May 19 '22 11:05 thewilsonator

Changelog?

It's part of the dip1000 by default transition: https://github.com/dlang/dmd/pull/14102

The larger issue here is that dip1000's story on delegates / nested functions is incomplete, both in implementation and specification. The goal is to fix that before 2.101. I'm opening this PR already to see how buildkite reacts.

dkorpel avatar May 19 '22 11:05 dkorpel

@RazvanN7 This is no longer blocked by buildkite, CI is green now (except unrelated std/logger/core failures)

dkorpel avatar Aug 30 '22 16:08 dkorpel