dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Default to `-defaultlib=` (no druntime/Phobos) for *.c tests

Open kinke opened this issue 3 years ago • 4 comments

kinke avatar May 01 '22 13:05 kinke

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14056"

dlang-bot avatar May 01 '22 13:05 dlang-bot

DMD codegen doesn't look too good (this works with LDC; some importC tests are disabled though). __builtin_va_end is apparently no builtin but a druntime import, and TypeInfos seem to be emitted into the supposedly C object files too.

kinke avatar May 01 '22 16:05 kinke

ImportC.h is in druntime and will presumably need to be tested at some point when preprocessing is more final.

maxhaton avatar May 01 '22 18:05 maxhaton

Filed https://issues.dlang.org/show_bug.cgi?id=23078.

kinke avatar May 02 '22 10:05 kinke