dmd icon indicating copy to clipboard operation
dmd copied to clipboard

CI: Use host dmd to compile dshell tests

Open MoonlightSentinel opened this issue 3 years ago • 2 comments

This ensures that a bug / breakage in the tested compiler doesn't prevent the actual test execution (because run.d aborts when the test tools fail to build).

The only drawback is that this limits the tests to the bootstrap compiler version.

MoonlightSentinel avatar Apr 13 '22 22:04 MoonlightSentinel

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13981"

dlang-bot avatar Apr 13 '22 22:04 dlang-bot

@MoonlightSentinel is this ready for review?

RazvanN7 avatar Apr 25 '22 13:04 RazvanN7