move apply from apply to aggregate

[thewilsonator]

apply is only used by aggregate.d and dclass.d and doesn't really belong in apply which should probably be named postorderVisitor

[dlang-bot]

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12596"

[thewilsonator]

urgh

src\dmd\tocvdebug.d(561): Error: function `dmd.aggregate.apply(Dsymbol symbol, int function(Dsymbol s, AggregateDeclaration agg) fp, AggregateDeclaration agg)` is not callable using argument types `(Dsymbol, extern (C++) int function(Dsymbol s, CvFieldList* pmc), CvFieldList*)`
src\dmd\tocvdebug.d(561):        cannot pass argument `& cv_mem_count` of type `extern (C++) int function(Dsymbol s, CvFieldList* pmc)` to parameter `int function(Dsymbol s, AggregateDeclaration agg) fp`
src\dmd\tocvdebug.d(572): Error: function `dmd.aggregate.apply(Dsymbol symbol, int function(Dsymbol s, AggregateDeclaration agg) fp, AggregateDeclaration agg)` is not callable using argument types `(Dsymbol, extern (C++) int function(Dsymbol s, CvFieldList* pmc), CvFieldList*)`
src\dmd\tocvdebug.d(572):        cannot pass argument `& cv_mem_p` of type `extern (C++) int function(Dsymbol s, CvFieldList* pmc)` to parameter `int function(Dsymbol s, AggregateDeclaration agg) fp`
src\dmd\tocvdebug.d(724): Error: function `dmd.aggregate.apply(Dsymbol symbol, int function(Dsymbol s, AggregateDeclaration agg) fp, AggregateDeclaration agg)` is not callable using argument types `(Dsymbol, extern (C++) int function(Dsymbol s, CvFieldList* pmc), CvFieldList*)`
src\dmd\tocvdebug.d(724):        cannot pass argument `& cv_mem_count` of type `extern (C++) int function(Dsymbol s, CvFieldList* pmc)` to parameter `int function(Dsymbol s, AggregateDeclaration agg) fp`
src\dmd\tocvdebug.d(775): Error: function `dmd.aggregate.apply(Dsymbol symbol, int function(Dsymbol s, AggregateDeclaration agg) fp, AggregateDeclaration agg)` is not callable using argument types `(Dsymbol, extern (C++) int function(Dsymbol s, CvFieldList* pmc), CvFieldList*)`
src\dmd\tocvdebug.d(775):        cannot pass argument `& cv_mem_p` of type `extern (C++) int function(Dsymbol s, CvFieldList* pmc)` to parameter `int function(Dsymbol s, AggregateDeclaration agg) fp`

[RazvanN7]

ping @thewilsonator

[thewilsonator]

@RazvanN7 pong. Apologies for the late response.

[thewilsonator]

Thanks!